Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger hover when dragging scene to rotate #1185

Closed
jleibs opened this issue Feb 10, 2023 · 1 comment · Fixed by #1198 or #1643
Closed

Don't trigger hover when dragging scene to rotate #1185

jleibs opened this issue Feb 10, 2023 · 1 comment · Fixed by #1198 or #1643
Assignees
@emilk
Labels
😤 annoying Something in the UI / SDK is annoying to use good first issue Good for newcomers ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented Feb 10, 2023 •
edited
Loading

Problem is pretty self-explanatory:

2023-02-10.15-03-32.mov
@jleibs jleibs added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use labels Feb 10, 2023
@emilk
Copy link
Member

emilk commented Feb 10, 2023

Just need to check ui.ctx().memory(|mem| mem.is_anything_being_dragged())

Wumpf added a commit that referenced this issue Feb 11, 2023
@Wumpf
Disable picking in spatial scenes while dragging (i.e. controlling th…
3f8da71 
…e camera)

Fixes #1185
@Wumpf Wumpf mentioned this issue Feb 11, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Feb 11, 2023
@Wumpf
Disable picking in spatial scenes while dragging (i.e. controlling th…
6900f9a 
…e camera) (#1198)

Fixes #1185
@Wumpf Wumpf reopened this Feb 11, 2023
@Wumpf Wumpf mentioned this issue Feb 11, 2023
Merged
3 tasks
@emilk emilk added the good first issue Good for newcomers label Feb 28, 2023
@emilk emilk self-assigned this Mar 21, 2023
emilk added a commit that referenced this issue Mar 21, 2023
@emilk
Don't hover things in 2D/3D views if we are dragging something
5e68e1f 
Closes #1185

…and unlike previous attempts, click-to-select still works
@emilk emilk mentioned this issue Mar 21, 2023
Merged
1 task
Wumpf pushed a commit that referenced this issue Mar 21, 2023
@emilk
Don't hover things in 2D/3D views if we are dragging something (#1643)
e41c992 
Closes #1185

…and unlike previous attempts, click-to-select still works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
😤 annoying Something in the UI / SDK is annoying to use good first issue Good for newcomers ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
3 participants
@emilk @Wumpf @jleibs