Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize text logs #1887

Closed
Tracked by #1898
emilk opened this issue Apr 17, 2023 · 3 comments
Closed
Tracked by #1898

Optimize text logs #1887

emilk opened this issue Apr 17, 2023 · 3 comments
Labels
🏹 arrow concerning arrow 📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself user-request This is a pressing issue for one of our users

Comments

@emilk
Copy link
Member

emilk commented Apr 17, 2023

We currently decode a full String for each text entry in the UI. This becomes really expensive for large text logs. This should instead be a shallow clone (Arced).

We should also take the time to split TextEntry into two components: text and level.
@emilk emilk added 📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself labels Apr 17, 2023
@teh-cmc teh-cmc mentioned this issue Apr 18, 2023
Closed
23 tasks
@emilk emilk mentioned this issue May 1, 2023
Merged
2 tasks
@emilk emilk added the 🏹 arrow concerning arrow label May 3, 2023
@emilk
Copy link
Member Author

emilk commented May 3, 2023

We can maybe use DataCell here

@emilk
Copy link
Member Author

emilk commented May 19, 2023

This is affecting some real users, who gets horrible FPS because of slow text logs.

@emilk emilk added the user-request This is a pressing issue for one of our users label Jun 27, 2023
@emilk emilk mentioned this issue Aug 8, 2023
Merged
3 tasks
@emilk emilk mentioned this issue Aug 30, 2023
Closed
@emilk
Copy link
Member Author

emilk commented Aug 30, 2023

@emilk emilk closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏹 arrow concerning arrow 📉 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emilk