Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for H264/H265/HVEC compressed images #5815

Open
karanchahal opened this issue Apr 5, 2024 · 6 comments
Open

Add support for H264/H265/HVEC compressed images #5815

karanchahal opened this issue Apr 5, 2024 · 6 comments
Labels
enhancement New feature or request 📉 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself 🕸️ web regarding running the viewer in a browser

Comments

@karanchahal
Copy link

My problem is I need to visualize multiple image data streams that are each of size 1920 x 1200 on the browser over a network connection. The current rerun support is quite spotty in this regard. It is laggy and the program kills itself after consuming some amount of RAM.

Describe the solution you'd like
Support for sending in h264 encoded image streams should be supported in Rerun and the viewer automatically decoding them on the frontend and displaying it.
Describe alternatives you've considered

Other approaches like reducing size of image is not a valid solution.
Additional context
This is a blocker to use this product in places where we need to see live robot visualization in a way that we can use teleoperation seemlessly. Perform calibration in an interactive manner etc.

I am doing this right now:

rr.log("image", rr.Image(cv2.resize(cv_image, (640, 480))))

I can see the image but at around 10 Hz which is not acceptable for our applications.

@karanchahal karanchahal added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 5, 2024
@Wumpf
Copy link
Member

Wumpf commented Apr 5, 2024

The browser version of Rerun is indeed particularly limited today: the viewer tries to keep everything uncompressed in ram and drops data once a pre-configured memory budget is reached. In the browser this even less viable than elsewhere since the memory budget is <4gb by design. Due to the continuous purging of old data when hitting the memory limit we should in theory not run out of memory, but I believe this could be the same issue as

(to be likely fixed in 0.16)

Generally, we're hoping to soon tackle the memory issue as part of

which is currently how we believe we'll be able to handle video streams and other larger than ram data in the future.

That leaves the really bad performance of ingesting even smaller images on the web for which I don't have a good answer right now, this is something we'll have to investigate and see what can be done about it. It's definitely not expected to be that bad, but I also don't think we did a lot of life streaming experiments with the web viewer.

I reckon for your usecase the native viewer is not an option? Could you (if possible) go a bit more into the details on why the web version of the viewer is what you need here?

@Wumpf Wumpf added 🕸️ web regarding running the viewer in a browser 📺 re_viewer affects re_viewer itself 📉 performance Optimization, memory use, etc and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 5, 2024
@Wumpf Wumpf changed the title H264 decoder on web based viewer H264 decoder on web based viewer, bad web image streaming performance Apr 5, 2024
@karanchahal
Copy link
Author

karanchahal commented Apr 5, 2024

I think it was bad because i was streaming uncompressed images of size 1920 x 1200.

it's much better if I add Image(<>).compress(). Its around 15 fps and if I bump down the image resolution to 640 x 480, I see around 30 Fps, which is much better.

But again, I think adding h264 support (maybe you can add an example of taking ros image data, running it through an image transport to encoded it to h264, stream it over the network, have rerun web visualizer be capable of hooking into a h264 stream (maybe HLS or WebRTC- not sure what is the best method to support this)) to rerun's open source offering will really help convince teams to onboard to this. Thanks very much ! Because there are a lot of applications where you need to visualize stuff running live on the robot and not from a ros bag.

Although, I do think this is not a trivial amount of work.

I reckon for your usecase the native viewer is not an option?

Yes, it is not an option, because viewers want to be able to view robot feeds on completely different devices and not hog system memory on the robot. Plus its easier to load it on the browser.

@emilk emilk changed the title H264 decoder on web based viewer, bad web image streaming performance Add support for H264/H265/HVEC compressed images Apr 7, 2024
@Wumpf
Copy link
Member

Wumpf commented Apr 10, 2024

able to view robot feeds on completely different devices

just in case you missed it: the sdk connects to the native viewer via tcp, so the viewer can run on any other device that's on the network. There's no requirement to have it run on the same device as the sdk

@karanchahal
Copy link
Author

karanchahal commented Apr 10, 2024 via email

@simgt
Copy link

simgt commented Apr 26, 2024

I'm using rerun to live stream data from a gstreamer pipeline, and being able to send h264 encoded frames would be extremely useful in that case. With the latest version that displays the size of a run, I realised that a 60MB video can take up to 2.5GB even though I'm downsizing the frames before sending them as Image, it's a bit of a waste.

Is there some notes on how this could be implemented?

I guess the main downside is that moving through the timeline would not be as instantaneous as now (which is amazing, by the way!).

@karanchahal
Copy link
Author

Yeah that a good point, I have a file that sends 640 x 480 images to the frontend and this captures around the same amount in a minute or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📉 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

No branches or pull requests

3 participants