Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DataCell::from_* and to_* functions with their try_* counterparts. #6399

Open
Artxiom opened this issue May 21, 2024 · 0 comments
Open

Replace DataCell::from_* and to_* functions with their try_* counterparts. #6399

Artxiom opened this issue May 21, 2024 · 0 comments
Labels
👀 needs triage This issue needs to be triaged by the Rerun team other Generated by the "Other" issue template

Comments

@Artxiom
Copy link
Contributor

Artxiom commented May 21, 2024

As discussed in PR #6380:
The functions DataCell::from_arrow, from_arrow_empty, to_native, etc. are just thin wrappers around their try_* counterparts. They only call unwrap() - and thus panic in case of an error.
It would be better to remove the wrappers and properly handle the error-case everywhere but this requires a refactoring of every call of these functions.

Related to #3408 and #6330.
@Artxiom Artxiom added other Generated by the "Other" issue template 👀 needs triage This issue needs to be triaged by the Rerun team labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👀 needs triage This issue needs to be triaged by the Rerun team other Generated by the "Other" issue template
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Artxiom