-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor usage of unwrap in re_db, re_format_arrow & re_log_types #6380
Merged
Wumpf
merged 7 commits into
rerun-io:main
from
Artxiom:6330-refactor-unwrap-re_log_types+
May 27, 2024
Merged
Refactor usage of unwrap in re_db, re_format_arrow & re_log_types #6380
Wumpf
merged 7 commits into
rerun-io:main
from
Artxiom:6330-refactor-unwrap-re_log_types+
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artxiom
force-pushed
the
6330-refactor-unwrap-re_log_types+
branch
from
May 17, 2024 19:12
1258b8e
to
5337b72
Compare
emilk
requested changes
May 20, 2024
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Artxiom
force-pushed
the
6330-refactor-unwrap-re_log_types+
branch
from
May 21, 2024 18:40
6974279
to
7df8a8f
Compare
emilk
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
emilk
added
🧑💻 dev experience
developer experience (excluding CI)
exclude from changelog
PRs with this won't show up in CHANGELOG.md
labels
May 21, 2024
there are some CI failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🧑💻 dev experience
developer experience (excluding CI)
exclude from changelog
PRs with this won't show up in CHANGELOG.md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Part of #6330
Removes or explicitly allows unwrap() where it makes sense.
Affected crates:
re_entity_db
,re_format_arrow
,and re_log_types
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.