Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide MsgId & InstanceId for on-hover ui #1017

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Hide MsgId & InstanceId for on-hover ui #1017

merged 3 commits into from
Feb 1, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 31, 2023

Fixes #1004

Before:
image

After:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

emilk
emilk approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should carefully consider if we ever want to show instance_key and msg_id. I'm voting no.

crates/re_viewer/src/ui/data_ui/instance_path.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/data_ui/instance_path.rs Show resolved Hide resolved
@Wumpf Wumpf merged commit dafe10b into main Feb 1, 2023
@Wumpf Wumpf deleted the andreas/hide-instance-and-msgid-from-hover branch February 1, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't show msg_id and instance in hover preview
2 participants
@Wumpf @emilk