Nicer frustum ray #1019
Merged
Nicer frustum ray #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes plane distance into account if nothing else is around
emilk
approved these changes
Feb 1, 2023
| .add_point(pos) | ||
| .radius(radius * 3.0) | ||
| .color(egui::Color32::WHITE); | ||
| // No harm in making this ray _very_ long. (Infinite messes with things though!) |
There was a problem hiding this comment.
as long as it is not counted into scene_bbox_accum 😬
(btw, I think the frustum box is perhaps counted to scene_bbox_accum, which messes up auto-camera-centering after having a large frustum distance)
There was a problem hiding this comment.
yes, frustum box is counted :/
and indeed this one is not because it comes after scene build up
not fond or the way we do the bounding box overall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes plane distance into account if nothing else is around
After:
With known depth:
Without known depth:
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)