Tensor view ui improvements #1022
Conversation
|
Nit: I think this would now look better with "flip" and "width/height" on the right, so that the "slots" are vertically aligned
|
There was a problem hiding this comment.
Really good improvements 👏
Maybe @nikolausWest want to take it for a spin before merge (otherwise he can take it for a spin after merge)
|
Super awesome! I still think the tensor view has some ways to go but I'll put the next round of problems in a new issue. One small thing: drop the quotes and colon |
|
@nikolausWest the quotes are in the sample, meaning the quotes are literally part of the dimension names and not something the viewer adds. We obv. don't want to mess witih the user names so don't want to remove them on the viewer. I'll check if that is easily fixed in the sample |
|
huh. okay something else is adding them along the way. Investigating |
also remove colon there
|
nvm fixed |
Fixes #1018 - compromise on (4), but otherwise this ticket describes point by point what was changed here.
-> Instead of adding a new space for selectors, we now allow selectors to be invisible in the ui. Started trying the alternative but not only was it quite hard to implement, the ui also didn't feel that good.
Also rearranged dimension mapper ui slightly as it never fitted the default selector width
Best reviewed commit by commit!
Before:
After:
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)