CI: Attempt to apply cancel-on-progress only on PR:s, not on main #1051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
cancel-in-progress: true
on our GitHub actions, so that new commits to a PR will cancel the currently running CI job, to make the queue shorter and save us CI-dollars.BUT I just noticed that this also applies to new commits to
main
, which means we have a trail of canceled CI jobs onmain
: https://github.com/rerun-io/rerun/commits/mainThis is an attempt to fix this. We won't know if it worked until we merge it!
I did make sure that the second commit to this PR canceled the first commit, so at least we haven't made things worse (it seems).
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)