Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Attempt to apply cancel-on-progress only on PR:s, not on main #1051

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 2, 2023

We use cancel-in-progress: true on our GitHub actions, so that new commits to a PR will cancel the currently running CI job, to make the queue shorter and save us CI-dollars.

BUT I just noticed that this also applies to new commits to main, which means we have a trail of canceled CI jobs on main: https://github.com/rerun-io/rerun/commits/main

This is an attempt to fix this. We won't know if it worked until we merge it!

I did make sure that the second commit to this PR canceled the first commit, so at least we haven't made things worse (it seems).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk marked this pull request as ready for review February 2, 2023 08:20
@emilk
Copy link
Member Author

emilk commented Feb 2, 2023

When this is approved, I'll merge it, then merge another PR (e.g. #1028) in quick succession, to test if this PR was effectual.

@emilk emilk merged commit 52a3108 into main Feb 2, 2023
@emilk emilk deleted the emilk/fix-ci-cancel-on-main branch February 2, 2023 09:06
@emilk
Copy link
Member Author

emilk commented Feb 2, 2023

Nope, this didn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants