Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fixes for Python Wheel release #1059

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Conversation

jondo2010
Copy link
Contributor

@jondo2010 jondo2010 commented Feb 2, 2023

This fixes a couple things on the python workflow:

  1. Correct eprintln to println in the rerun_py/build.rs
  2. Added change detection based on the relevant ENV variables in case the output of the build.rs gets cached.
  3. Removed CHANGELOG.md from the deployed files list, since it's not actually available at that stage.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@jondo2010 jondo2010 marked this pull request as ready for review February 2, 2023 16:32
John Hughes added 2 commits February 3, 2023 10:35
* Patch Cargo.toml with a scripts/patch_prerelease_version.py now
@@ -144,6 +148,10 @@ jobs:
cache: "pip"
cache-dependency-path: "rerun_py/requirements-build.txt"

- name: Patch Cargo.toml for Pre-Release
#if: github.ref == 'refs/heads/main'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment this before merge, used for testing in PR

@jondo2010 jondo2010 merged commit a0197ae into main Feb 3, 2023
@jondo2010 jondo2010 deleted the john/workflow_fixes branch February 3, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants