Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw meshes: support albedo factors, clean up examples and acknowledge lack of support for .obj #1081

Merged
merged 10 commits into from
Feb 3, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 3, 2023

  • We already support albedo factors for encoded meshes, so I just piggy backed on that for raw meshes; that way we just punt on any vertex-buffer related questions.
  • We used to behave like we support .obj files, except we haven't for a while.
  • Fixed all the dataset download mess in the deep_sdf and raw_mesh examples (I hope).

python (./examples/raw_mesh/main.py --scene buggy) vs. rust (cargo r -p raw_mesh -- examples/deep_sdf/dataset/downloaded/buggy/buggy.glb):

23-02-03_17.28.18.patched.mp4

@teh-cmc teh-cmc marked this pull request as draft February 3, 2023 16:06
@teh-cmc teh-cmc marked this pull request as ready for review February 3, 2023 16:14
@jondo2010 jondo2010 self-requested a review February 3, 2023 16:28
@teh-cmc
Copy link
Member Author

teh-cmc commented Feb 3, 2023

that was fast 👀 thanks!

@teh-cmc teh-cmc merged commit eff9ddb into main Feb 3, 2023
@teh-cmc teh-cmc deleted the cmc/raw_mesh/colors branch February 3, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants