Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tensor view margins #1091

Merged
merged 9 commits into from
Feb 4, 2023
Merged

Improve tensor view margins #1091

merged 9 commits into from
Feb 4, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 4, 2023

image

Best reviewed ignoring whitespace changes

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@Wumpf Wumpf self-requested a review February 4, 2023 10:15
Wumpf
Wumpf approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhh that looks super nice with those dark rounded boxes! Remove on hover also makes more sense :)

crates/re_viewer/src/ui/view_tensor/ui.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/view_tensor/ui.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 3bf2aeb into main Feb 4, 2023
@emilk emilk deleted the emilk/tensor-view-margins branch February 4, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf