Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Selection color from design token #1092

Merged
merged 5 commits into from
Feb 5, 2023
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 4, 2023

I set out to apply various other design tokens, but after having a closer look at how not all our design sketches use the exact same colors and the existing struggle in design_tokens.rs, I did only this one impactful one
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk
Copy link
Member

emilk commented Feb 4, 2023

Is it just me, or is that a lot uglier? 😬

@Wumpf
Copy link
Member Author

Wumpf commented Feb 4, 2023

fits better into the dark design I believe, but I might be just biased by being used to the other color, so this looks new and shiny to me
no strong opinion either way 🤷

@nikolausWest
Copy link
Member

I think I like this color better

@emilk
Copy link
Member

emilk commented Feb 5, 2023

let's try it then

@emilk emilk merged commit 80d3247 into main Feb 5, 2023
@emilk emilk deleted the andreas/various-design-tokens branch February 5, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants