Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore previous non-tracked camera pose on esc #1102

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 5, 2023

Allow the user to revert to the previous camera pose whenever a 3d camera is tracked.

Screen.Recording.2023-02-05.at.20.23.12.mov

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

It would be great if both this and the "click on camera" behavior was documented in HELP_TEXT_3D. We should strive to not have too many hidden features.

@Wumpf
Copy link
Member Author

Wumpf commented Feb 5, 2023

yeah this was mostly meant as a quick and dirty fix for Niko's recording woes which then got good enough to land :)
Considering this again I'd like to encapsulate state_3d's camera state a bit better because there is now a high risk all these different states get out of sync.
Also there is the matter of the somewhat odd "you need to hover this space view and then press Escape" which on one hand is weird and on the other hand totally necessary because otherwise we react on Esc in all sort of contexts. But I'm wondering if there is another way of expressing "this view has focus"

@Wumpf Wumpf merged commit 0c9936e into main Feb 6, 2023
@Wumpf Wumpf deleted the andreas/restore-camera-pose-on-esc branch February 6, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants