Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Selection to Item, MultiSelection to ItemCollection #1104

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Rename Selection to Item, MultiSelection to ItemCollection #1104

merged 1 commit into from
Feb 6, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 6, 2023

These are better names since Item is used for more than just selections.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@Wumpf Wumpf self-requested a review February 6, 2023 12:18
Wumpf
Wumpf approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeeees!

@Wumpf Wumpf merged commit 1875e0a into main Feb 6, 2023
@Wumpf Wumpf deleted the emilk/refactor-item branch February 6, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf