Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a grid in entity properties ui #1106

Merged
merged 5 commits into from
Feb 6, 2023
Merged

Use a grid in entity properties ui #1106

merged 5 commits into from
Feb 6, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 6, 2023

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@Wumpf
Copy link
Member

Wumpf commented Feb 6, 2023

colons still need to go

Wumpf
Wumpf approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is better with grids

crates/re_viewer/src/ui/selection_panel.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/selection_panel.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/selection_panel.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/selection_panel.rs Outdated Show resolved Hide resolved
emilk and others added 4 commits February 6, 2023 15:56
@emilk @Wumpf
no colons
76aefe3 
Co-authored-by: Andreas Reich <andreas@rerun.io>
@emilk @Wumpf
Entity
0348a71 
Co-authored-by: Andreas Reich <andreas@rerun.io>
@emilk @Wumpf
Entity
327c79b 
Co-authored-by: Andreas Reich <andreas@rerun.io>
@emilk @Wumpf
no colons, no bullshit
e399af4 
Co-authored-by: Andreas Reich <andreas@rerun.io>
@Wumpf Wumpf merged commit 973a989 into main Feb 6, 2023
@Wumpf Wumpf deleted the emilk/more-ui-grid branch February 6, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf