Switch ci_docker to a container based on ubuntu 20.04 #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
added
🛞 build wheels
🐧 linux
jondo2010
reviewed
Feb 16, 2023
| @@ -105,15 +105,20 @@ jobs: | |||
|
|
|||
| runs-on: ${{ matrix.runs_on }} | |||
|
|
|||
| container: ${{ matrix.container }} | |||
There was a problem hiding this comment.
Oh that's cool that this falls through to "no container" if the value doesn't exist in the matrix
jondo2010
reviewed
Feb 16, 2023
|
Looks like you need |
jleibs
changed the title
jleibs
force-pushed
the
jleibs/ubuntu_2204_docker
branch
from
977d122
to
858d14d
Compare
emilk
approved these changes
Feb 17, 2023
| # So we only run the script on !Windows, and then on Windows we do the parts of the script manually. | ||
| # That way we still get to test the script on Linux and Mac. | ||
| # Also we can't run it on linux because the 20.04 Docker container will install | ||
| # an old version of binaryen/wasm-opt that barfs on the `--fast-math` flag |
There was a problem hiding this comment.
Hum… we probably shouldn't be using the --fast-math flag, but installing the most recent binaryen/wasm-opt seems like a good idea anyway
|
Tested on Arch ✅ |
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reasonable, reproducible container for a common LTS release.
It contains glibc-2.31 and python-3.8, giving us a better degree of manylinux compatibility when building wheels.
The "best" way to build for maximum compatibilityu would be using one of the centos manylinux containers, but the containers that have the version of glibc that we would like are missing the required gtk-3 deps. This seems like a reasonable compromise.
This container has all the same deps as our normal rust build CI containers, so just use it for everything to keep stuff straight-forward.
In the process of avoiding some other sharp-corners on ubuntu I also modified things to just build the wheel once and then patch the .rrd into it after the fact.
Wheels available from: https://github.com/rerun-io/rerun/suites/11039049133/artifacts/560751373
TODO:
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)