Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix path issues when running debug viewer within workspace #1341

Merged
merged 1 commit into from Feb 17, 2023
Merged

Fix path issues when running debug viewer within workspace #1341

merged 1 commit into from Feb 17, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 17, 2023 •
edited

Fixes #1258.
Requires #1339.

Checklist:

  • native debug from within at root
  • native debug from within not at root
  • native debug from outside
  • web debug from within at root
  • web debug from within not at root
  • web debug from outside

@teh-cmc teh-cmc changed the base branch from main to cmc/include_file_errors February 17, 2023 09:37
@teh-cmc teh-cmc added 🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself labels Feb 17, 2023
@Wumpf Wumpf self-requested a review February 17, 2023 09:55
Wumpf
Wumpf approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Good you did all the testing now :)

Base automatically changed from cmc/include_file_errors to main February 17, 2023 10:06
@teh-cmc teh-cmc merged commit e333e2c into main Feb 17, 2023
@teh-cmc teh-cmc deleted the cmc/cargo_run_everywhere branch February 17, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running the viewer in debug from within workspace only works when sitting at the root
2 participants
@teh-cmc @Wumpf