Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use python3 in the jobs that weren't tested in PR #1348

Merged
merged 1 commit into from Feb 17, 2023
Merged

Use python3 in the jobs that weren't tested in PR #1348

merged 1 commit into from Feb 17, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 17, 2023

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@jleibs jleibs marked this pull request as ready for review February 17, 2023 15:53
@jleibs jleibs added the 🧑‍💻 dev experience developer experience (excluding CI) label Feb 17, 2023
emilk
emilk reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chmod +x it instead? It already has the correct shebang

@jleibs
Copy link
Member Author

jleibs commented Feb 17, 2023

chmod +x it instead? It already has the correct shebang

I'll experiment with that in a future PR... I anticipate more sharp corners around github runners, executability flags, and shell context ! path behavior.

@jleibs jleibs merged commit df920dc into main Feb 17, 2023
@jleibs jleibs deleted the jleibs/use_python3_in_ci branch February 17, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk left review comments

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jleibs @emilk