Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all instances of frame_maintenance to begin_frame #1360

Merged
merged 2 commits into from Feb 20, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 20, 2023

Comments already indicated that it should be called at the beginning of a frame!

This is a pure search & replace PR.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

Comments already indicated that it should be called at the beginning of a frame!
@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label Feb 20, 2023
@Wumpf Wumpf merged commit afd74ec into main Feb 20, 2023
@Wumpf Wumpf deleted the andreas/re_renderer/rename-beginframe branch February 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants