Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster stable diffusion #1364

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Faster stable diffusion #1364

merged 3 commits into from
Feb 21, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 21, 2023

The stable_diffusion example had a bug that caused two parameters to be hard-coded (guidance_scale and num_inference_steps, even though there were arguments to ostensibly set these.

num_inference_steps was hard-coded to 70, which means the example takes a looooong time to run on the CPU. This in-particular would grind just py-run-all to a half during testing.

I fixed the bugs, simplified the code, and lowered num_inference_steps to 10. The result is quite noisy, but serviceable, and users can (now) control it with --num_inference_steps.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk added 🐍 Python API Python logging API examples Issues relating to the Rerun examples labels Feb 21, 2023
@emilk emilk merged commit 7281184 into main Feb 21, 2023
@emilk emilk deleted the emilk/faster-stable-diffusion branch February 21, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants