Put all analytics to one bucket #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Actually, |
teh-cmc
approved these changes
Feb 24, 2023
emilk
added a commit
that referenced
this pull request
Mar 2, 2023
* Put all all analytics into the prod bucket * Add properties for debug-build and workspace * workspace -> rerun_workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1389
This puts all analytics events in the same bucket (our prod-bucket) to make it easy to see if the same user switches from using a published package to building from source.
It also adds two new propertis:
debug- built withdebug_assertionsenabledrerun_workspace, a proxy for "user checked out the project and built it from source"Perhaps we can come up with better names for these that are both descriptive and accurate?
from_repository?