Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash-on-save by switching file-picker dialog to xdg-portal #1402

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 24, 2023

Not ready to merge yet, but want to create CI-built wheels.

In particular need to figure out alternative to the MessageDialogs.

Resolves: #1315

Test wheels from CI:

  • Ubuntu 20.10
  • Ubuntu 20.04
  • Arch (with xdg-desktop-portal-gtk)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@jleibs jleibs added 💣 crash crash, deadlock/freeze, do-no-start 🛞 build wheels 🪳 bug Something isn't working labels Feb 24, 2023
@@ -2,10 +2,6 @@ name: CI (Python)

on:
pull_request:
paths:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to restrict wheel-building to only when we have changed python code.

  1. We want to catch if if we break the wheel by changing rust code
  2. We want to be able to build new wheels based on changes to the rust code

@teh-cmc
Copy link
Member

teh-cmc commented Feb 26, 2023

Unsurprisingly: doesn't work on an Arch system with nothing but a wlroots based WM installed, though it did work for @jleibs running on a wlroots WM that is installed on a Ubuntu with (likely) other xdg-portals running in the background.

@emilk
Copy link
Member

emilk commented Mar 2, 2023

Blocked by new release of rfd containing

@emilk emilk added the blocked can't make progress right now label Mar 2, 2023
@PolyMeilex
Copy link

Unsurprisingly: doesn't work on an Arch system with nothing but a wlroots based WM installed, though it did work for @jleibs running on a wlroots WM that is installed on a Ubuntu with (likely) other xdg-portals running in the background.

On wlroots systems, one would be expected to have xdg-portal-wlr (for wlroots specific stuff like screen share) and xdg-portal-gtk (for everything else) running, same would apply to X11 setups like i3wm or any other WM, but obviously people don't run them for the sake of "bloat" free experience. That's the main reason why it is still not a default backend of RFD.

In particular need to figure out alternative to the MessageDialogs.

That's planed already, I want to use Zenity (and KDialog) for that in RFD, just haven't had the time to do that. Eventually I would like to remove GTK all together in favor of Zenity, and use it as fallback only for those "bloat" free systems.

@teh-cmc
Copy link
Member

teh-cmc commented Mar 6, 2023

Hey @PolyMeilex, thanks for the heads up.

I've tried installing xdg-portal-kde alongside my xdg-portal-wlr before but that didn't help sadly; I'll try with xdg-portal-gtk then.

I'll also try your Zenity branch while I'm at it then. Will get back to you asap.

@teh-cmc
Copy link
Member

teh-cmc commented Mar 6, 2023

Can confirm that both Message and File dialogs work fine for me using the zenity branch, on a stripped down Arch/wlroots setup, provided there's an extra xdg-desktop-portal-gtk running in the background 🎊

@emilk
Copy link
Member

emilk commented Mar 25, 2023

rfd 0.11.3 has been released, and I've updated to it. Please test this @teh-cmc !

EDIT: ouch, that's A LOT of new dependencies… 😬

@emilk emilk marked this pull request as ready for review March 25, 2023 15:39
@@ -2,6 +2,7 @@ name: CI (Python)

on:
pull_request:
types: [labeled, synchronize, opened]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional or merge conflict?

@teh-cmc
Copy link
Member

teh-cmc commented Mar 27, 2023

Yep, dialogs working fine over here

@emilk
Copy link
Member

emilk commented Mar 27, 2023

I'll see if I can fix the duplicated deps and get cargo deny happy

@emilk
Copy link
Member

emilk commented Mar 27, 2023

I believe this is ready to be merged then

@emilk emilk merged commit 2a62c32 into main Mar 27, 2023
@emilk emilk deleted the jleibs/xdg_portal branch March 27, 2023 11:29
@emilk emilk changed the title Switch file-picker dialog to xdg-portal Fix crash-on-save by switching file-picker dialog to xdg-portal Mar 27, 2023
@emilk emilk removed the blocked can't make progress right now label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewer freezes/crashes on save
4 participants