-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate depth clouds into Rerun #1421
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
db87ebf
implement depth cloud renderer
teh-cmc ea87f88
proper rp config
teh-cmc 931b468
self-review
teh-cmc 0ee30e1
handle breaking changes from main
teh-cmc 66729fe
upload depth textures through staging belt
teh-cmc 981ddfc
addressing PR comments part 1 of N
teh-cmc 90ecd3d
work around wgpu d16 web issue
teh-cmc f8bd1fc
addressing PR comments part 2 of N
teh-cmc ad9b19e
big refactoring of the whole quad spanning story
teh-cmc 3d79fd6
accomodating breaking changes
teh-cmc 85f40ca
bring back coverage
teh-cmc 5e84d89
todos
teh-cmc 6dd8819
procedural example
teh-cmc e564ce3
clean
teh-cmc 2114e22
fix wasm cranky
teh-cmc d12a5b9
set up entity props & selection panel for backprojection
teh-cmc 0335097
integrate depth clouds into rerun
teh-cmc 2356b33
last merge conflicts
teh-cmc e157911
huh, nasty
teh-cmc cb9d705
everything working as i want
teh-cmc 7cf4fd0
cleanin up
teh-cmc 6581a98
self review
teh-cmc 007c81b
Merge branch 'main' into cmc/depth_clouds_integration
teh-cmc 3588352
Merge branch 'main' into cmc/depth_clouds_integration
teh-cmc 4c0ad58
compute auto heuristics properly
teh-cmc a9c1fb1
gentle radius scale
teh-cmc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given that the way you wrote the matrix up seems to be the "normal way" and that you moved out the transpose from the shader, maybe the transpose should be on
renderer/depth_cloud.rs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm writing the matrix as if the constructor accepted rows rather than columns (cause I find it easier to read), so i should be the one transposing back no?