heuristic for camera frustum length is now based on scene size #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces `EditableAutoValue` and per-frame heuristic updates on properties. In the future we can build more properties on top of this and update them in a central place like done here
teh-cmc
approved these changes
Feb 28, 2023
| @@ -0,0 +1,43 @@ | |||
| /// A value that is either determined automatically by some heuristic, or specified by the user. | |||
There was a problem hiding this comment.
We're adding more and more things to re_data_store that don't seem to be related at all to the data store 🤔
There was a problem hiding this comment.
Yeah, the properties are misplaced there in the first place I think
crates/re_viewer/src/ui/view_spatial/scene/scene_part/cameras.rs
Outdated
Show resolved
Hide resolved
3 tasks
emilk
pushed a commit
that referenced
this pull request
Mar 2, 2023
Introduces `EditableAutoValue` and per-frame heuristic updates on properties. In the future we can build more properties on top of this and update them in a central place like done here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
EditableAutoValueand per-frame heuristic updates on properties. In the future we can build more properties on top of this and update them in a central place like done hereReplaces #916
Fixes #681
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)