Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement outlines for line renderer & use them for select & hover of "line-like" primitives in Viewer #1553

Merged
merged 10 commits into from
Mar 10, 2023
Merged

Implement outlines for line renderer & use them for select & hover of "line-like" primitives in Viewer #1553

merged 10 commits into from
Mar 10, 2023

Commits on Mar 10, 2023

  1. line batches (!) support now outline masks

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d4238e5 View commit details
    Browse the repository at this point in the history

  2. wip 

    # Conflicts:
#	crates/re_viewer/src/misc/selection_state.rs
    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    88a1c46 View commit details
    Browse the repository at this point in the history

  3. Allow outlines for individual line strip ranges

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1288e0d View commit details
    Browse the repository at this point in the history

  4. remove unnecessary lifetimes from selection_state

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    903e016 View commit details
    Browse the repository at this point in the history

  5. use outline driven highlights for all kinds of line primitives

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    83f8d03 View commit details
    Browse the repository at this point in the history

  6. more aggressive coverage discard for rounded line outlines 

    Looks a lot better on rectangles
    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9a82aff View commit details
    Browse the repository at this point in the history

  7. tweak selection outline style a bit

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    1ee2461 View commit details
    Browse the repository at this point in the history

  8. change outline depth test for overwritability by same depth value

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    12854b6 View commit details
    Browse the repository at this point in the history

  9. tweak how outlines deal with coverage mask on lines

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9955c28 View commit details
    Browse the repository at this point in the history

  10. rename outline_mask to outline_mask_ids

    @Wumpf
    Wumpf committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5862ca6 View commit details
    Browse the repository at this point in the history