Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renderer: fix the groupby logic in mesh instancing #1657

Merged
merged 2 commits into from Mar 21, 2023
Merged

renderer: fix the groupby logic in mesh instancing #1657

merged 2 commits into from Mar 21, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 21, 2023 •
edited

Fixes #1530

@teh-cmc teh-cmc added the 🔺 re_renderer affects re_renderer itself label Mar 21, 2023
@Wumpf Wumpf self-requested a review March 21, 2023 16:35
Wumpf
Wumpf approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, thank you!

@Wumpf Wumpf merged commit 28feae8 into main Mar 21, 2023
@Wumpf Wumpf deleted the cmc/renderer/mesh_instancing_groupby branch March 21, 2023 16:41
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mesh instancing/batching is broken
2 participants
@teh-cmc @Wumpf