Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the depth backprojection feature #1690

Merged
merged 29 commits into from
Mar 24, 2023
Merged

Improve the depth backprojection feature #1690

merged 29 commits into from
Mar 24, 2023

Commits on Mar 23, 2023

  1. Replace the backproject scale with the familiar "meter"

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4df37f1 View commit details
    Browse the repository at this point in the history

  2. Assume depth images usually start at zero

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    61faf43 View commit details
    Browse the repository at this point in the history

  3. Make the depth point radius scale more sane

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    e18a1c5 View commit details
    Browse the repository at this point in the history

  4. Fix an off-by-half error, giving all points an extra 0.5 pixels in ra… 

    …dius
    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f783c0f View commit details
    Browse the repository at this point in the history

  5. Add a fudge-factor

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    89faaf8 View commit details
    Browse the repository at this point in the history

  6. Improve tooltip

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    8594073 View commit details
    Browse the repository at this point in the history

  7. Fix typos

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9034c5c View commit details
    Browse the repository at this point in the history

  8. Fix doclink

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    5cb4e2d View commit details
    Browse the repository at this point in the history

  9. Fix the math

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    0317372 View commit details
    Browse the repository at this point in the history

  10. fix typo 

    Co-authored-by: Andreas Reich <andreas@rerun.io>
    @emilk @Wumpf
    emilk and Wumpf committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a7fbbfc View commit details
    Browse the repository at this point in the history

  11. #[inline]

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    3deb14c View commit details
    Browse the repository at this point in the history

  12. Another typo

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    ed32db8 View commit details
    Browse the repository at this point in the history

  13. typo 

    Co-authored-by: Andreas Reich <andreas@rerun.io>
    @emilk @Wumpf
    emilk and Wumpf committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    13d4844 View commit details
    Browse the repository at this point in the history

  14. Adjust the feathering margins

    @emilk
    emilk committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2b103f2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Clean up the depth texture uploading

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    f661a25 View commit details
    Browse the repository at this point in the history

  2. Better docs

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    5603fa0 View commit details
    Browse the repository at this point in the history

  3. fix typos

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    37d8725 View commit details
    Browse the repository at this point in the history

  4. Use world depth values in the shader and simplify user code

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    4964a54 View commit details
    Browse the repository at this point in the history

  5. Better naming

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    0e72422 View commit details
    Browse the repository at this point in the history

  6. Fix bug in the image-hover code

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    d5ee3c1 View commit details
    Browse the repository at this point in the history

  7. Use same depth range for the color map in the depth projection shader

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    51a21ac View commit details
    Browse the repository at this point in the history

  8. Fix the gamma of the wgsl color map

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2c72031 View commit details
    Browse the repository at this point in the history

  9. Tweak default point radius to avoid Moiré patterns

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8134e8a View commit details
    Browse the repository at this point in the history

  10. Final touches

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    f489b2a View commit details
    Browse the repository at this point in the history

  11. spell fix

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e321037 View commit details
    Browse the repository at this point in the history

  12. more typos 

    Co-authored-by: Andreas Reich <andreas@rerun.io>
    @emilk @Wumpf
    emilk and Wumpf committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    f2e1484 View commit details
    Browse the repository at this point in the history

  13. Fix comment about why we use Depth16Unorm

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    21cfdcf View commit details
    Browse the repository at this point in the history

  14. Add lines to changelog

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ea8c05e View commit details
    Browse the repository at this point in the history

  15. max_depth -> max_depth_in_world

    @emilk
    emilk committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ca8b777 View commit details
    Browse the repository at this point in the history