Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python SDK: multi-recording & multi-threading redesign #2061

Merged
merged 26 commits into from
May 15, 2023
Merged

Python SDK: multi-recording & multi-threading redesign #2061

merged 26 commits into from
May 15, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented May 9, 2023 •
edited
Loading

Implements multi-recording support in the Python SDK, as discussed during walkthrough.

⚠️ rr.set_active is gone (deprecated for a looong time) ⚠️

Fixes #1903
On top of #2110

TODO:

  • pass over doc strings
  • handle the couple TODOs left, nothing major
  • use Jeremy's RecordingType'
  • create issues for future work

Future work:

@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch 3 times, most recently from 4999da3 to a470a85 Compare May 9, 2023 09:36
@teh-cmc teh-cmc changed the title Python SDK: multi-recording redesign Python SDK: multi-recording & multi-threading redesign May 9, 2023
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch from a470a85 to bffaafe Compare May 9, 2023 13:04
@teh-cmc teh-cmc mentioned this pull request May 9, 2023
Closed
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch 5 times, most recently from 883964d to 870faad Compare May 11, 2023 06:47
teh-cmc
teh-cmc commented May 11, 2023
View reviewed changes
Copy link
Member Author

@teh-cmc teh-cmc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

crates/re_sdk/src/global.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/global.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/global.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/lib.rs Outdated Show resolved Hide resolved
crates/re_sdk/src/lib.rs Outdated Show resolved Hide resolved
rerun_py/src/python_bridge.rs Outdated Show resolved Hide resolved
rerun_py/src/python_bridge.rs Show resolved Hide resolved
rerun_py/src/python_bridge.rs Outdated Show resolved Hide resolved
rerun_py/src/python_bridge.rs Outdated Show resolved Hide resolved
rerun_py/src/python_bridge.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch 2 times, most recently from 61df41f to 51c97c7 Compare May 11, 2023 16:05
@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API labels May 11, 2023
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch from 51c97c7 to d473cd6 Compare May 11, 2023 16:38
@teh-cmc teh-cmc marked this pull request as ready for review May 11, 2023 16:42
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch 2 times, most recently from c2216ea to d2a18c9 Compare May 11, 2023 16:52
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch from 4f0ed98 to e3e9a91 Compare May 11, 2023 17:54
jleibs
jleibs approved these changes May 12, 2023
View reviewed changes
crates/re_sdk/src/global.rs Outdated Show resolved Hide resolved
rerun_py/rerun_sdk/rerun/__init__.py Outdated Show resolved Hide resolved
@teh-cmc teh-cmc mentioned this pull request May 15, 2023
Merged
2 tasks
@teh-cmc teh-cmc changed the base branch from main to jleibs/explicit_recording_ids May 15, 2023 10:23
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch from 8fcd9aa to eeb91eb Compare May 15, 2023 14:03
@teh-cmc teh-cmc force-pushed the cmc/py/recordingstream_exposed branch from eeb91eb to 59f79cc Compare May 15, 2023 14:21
Base automatically changed from jleibs/explicit_recording_ids to main May 15, 2023 16:18
@teh-cmc teh-cmc merged commit ad4c38c into main May 15, 2023
15 checks passed
@teh-cmc teh-cmc deleted the cmc/py/recordingstream_exposed branch May 15, 2023 16:50
@jleibs jleibs mentioned this pull request May 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update python APIs to make init return a RecordingHandle which manages most state
2 participants
@teh-cmc @jleibs