Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check examples/python/requirements.txt in CI #2063

Merged
merged 5 commits into from
May 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/reusable_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ jobs:
- name: Check for too large files
run: |
./scripts/check_large_files.sh

- name: Check Python example requirements
run: |
./scripts/check_requirements.py

# ---------------------------------------------------------------------------

Expand Down
6 changes: 6 additions & 0 deletions examples/python/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
-r api_demo/requirements.txt
-r arkitscenes/requirements.txt
-r car/requirements.txt
-r clock/requirements.txt
-r colmap/requirements.txt
-r deep_sdf/requirements.txt
-r dicom/requirements.txt
-r dna/requirements.txt
-r minimal/requirements.txt
-r mp_pose/requirements.txt
-r multiprocessing/requirements.txt
-r multithreading/requirements.txt
-r notebook/requirements.txt
-r nyud/requirements.txt
-r objectron/requirements.txt
-r opencv_canny/requirements.txt
-r plots/requirements.txt
-r raw_mesh/requirements.txt
-r ros/requirements.txt
-r segment_anything/requirements.txt
-r stable_diffusion/requirements.txt
-r text_logging/requirements.txt
-r tracking_hf_opencv/requirements.txt
45 changes: 45 additions & 0 deletions scripts/check_requirements.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
#!/usr/bin/env python3

import os
from glob import glob


def main() -> None:
failed = False

print("Checking `examples/python/requirements.txt`...")
with open("examples/python/requirements.txt") as f:
lines = f.read().strip().splitlines()
sorted_lines = lines.copy()
sorted_lines.sort()
requirements = set(lines)

missing = []
for path in glob("examples/python/*/requirements.txt"):
line = f"-r {os.path.relpath(path, 'examples/python')}"
if line not in requirements:
missing.append(line)

if len(missing) != 0:
print("\n`examples/python/requirements.txt` is missing the following requirements:")
for line in missing:
print(line)
failed = True

if lines != sorted_lines:
print("\n`examples/python/requirements.txt` is not correctly sorted.")
failed = True

if failed:
print("\nHere is what `examples/python/requirements.txt` should contain:")
expected = glob("examples/python/*/requirements.txt")
expected.sort()
for path in expected:
print(f"-r {os.path.relpath(path, 'examples/python')}")
exit(1)
else:
print("All clear.")


if __name__ == "__main__":
main()
Loading