Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordingStream: automatic log_tick timeline #2072

Merged
merged 6 commits into from May 9, 2023
Merged

RecordingStream: automatic log_tick timeline #2072

merged 6 commits into from May 9, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented May 9, 2023

Introduces a new per-recording per-process log_tick timeline, automatically derived on behalf of the user.

Future work:

  • Pick the right timeline from blueprint and/or based on context!

#2042

@teh-cmc teh-cmc added 🏹 arrow concerning arrow ⛃ re_datastore affects the datastore itself labels May 9, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks easy enough!

@teh-cmc teh-cmc merged commit fb02dfa into main May 9, 2023
15 checks passed
@teh-cmc teh-cmc deleted the cmc/log_tick branch May 9, 2023 16:13
jprochazk pushed a commit that referenced this pull request May 11, 2023
* RecordingStream: automatic log_tick timeline (per-recording, per-process)

* adjust default timeline heuristics to account for 'log_tick'

* use our timeline constants everywhereg

* timeless-ness shenanigans

* more docs

* issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow ⛃ re_datastore affects the datastore itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants