Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Clipboard::set_text #2078

Merged
merged 2 commits into from May 10, 2023
Merged

Remove Clipboard::set_text #2078

merged 2 commits into from May 10, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented May 10, 2023

Motivation: #2069 (comment)

re_viewer_context::Clipboard is for copying images. We should probably remove the set_text footgun in it. egui/eframe supports copy-and paste on web

@teh-cmc teh-cmc added the 🧑‍💻 dev experience developer experience (excluding CI) label May 10, 2023
@emilk emilk merged commit f775900 into main May 10, 2023
15 checks passed
@emilk emilk deleted the cmc/its_a_trap branch May 10, 2023 10:52
jprochazk pushed a commit that referenced this pull request May 11, 2023
@teh-cmc @jprochazk
Remove Clipboard::set_text (#2078)
885961c 
* remove Clipboard::set_text

* remove sole usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teh-cmc @emilk