tornado >6.1 doesn't work with recent jupyter
#2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
approved these changes
May 11, 2023
emilk
reviewed
May 11, 2023
| @@ -1,3 +1,4 @@ | |||
| ipython<=8.12 # ipython 8.13 or greater doesn't work with python 3.8 | |||
| tornado<=6.1 # later versions don't work with recent jupyter releases... | |||
There was a problem hiding this comment.
Please note which version doesn't work. If it is 6.2 that is broken now, maybe it is time to re-asses when tornado 7.0 is released, for instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any version more recent than that will cause random crashes/deadlocks/etc, see e.g. https://youtrack.jetbrains.com/issue/DS-4883.
And so we pin it...
PR Build Summary: https://build.rerun.io/pr/2092