Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flushing race in new multi-recording SDK #2125

Merged
merged 2 commits into from
May 16, 2023
Merged

Fix flushing race in new multi-recording SDK #2125

merged 2 commits into from
May 16, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented May 15, 2023 •
edited by emilk
Loading

Fixes #2124
Fixes #2150

PR Build Summary: https://build.rerun.io/pr/2125

@teh-cmc teh-cmc changed the title add minimal to the e2e test (catches 2fast2flush race) Fix flushing race in new multi-recording SDK May 15, 2023
@teh-cmc teh-cmc added the 🪳 bug Something isn't working label May 15, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented May 15, 2023

image

As one would expect!

@teh-cmc teh-cmc marked this pull request as ready for review May 15, 2023 22:26
@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label May 16, 2023
@teh-cmc
Copy link
Member Author

teh-cmc commented May 16, 2023

Added do-not-merge, want to talk about it first!

@emilk emilk mentioned this pull request May 16, 2023
Closed
14 tasks
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label May 16, 2023
@teh-cmc teh-cmc merged commit 30e7d63 into main May 16, 2023
16 of 17 checks passed
@teh-cmc teh-cmc deleted the cmc/what_did_i_break branch May 16, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🪳 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

./examples/python/text_logging/main.py is broken Applications that exit too quickly fail to flush their data
1 participant
@teh-cmc