Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeingRecordingMsg -> SetRecordingInfo #2149

Merged
merged 2 commits into from May 16, 2023
Merged

BeingRecordingMsg -> SetRecordingInfo #2149

merged 2 commits into from May 16, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented May 16, 2023

Just getting #1996 out of the way

@teh-cmc teh-cmc linked an issue May 16, 2023 that may be closed by this pull request
BeginRecordingMsg is a misnomer #1996
Closed
@teh-cmc teh-cmc added the 🚜 refactor Change the code, not the functionality label May 16, 2023
@teh-cmc teh-cmc merged commit 6b7f0f8 into main May 16, 2023
17 of 18 checks passed
@teh-cmc teh-cmc deleted the cmc/set_recording_info branch May 16, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BeginRecordingMsg is a misnomer
2 participants
@teh-cmc @emilk