Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo test #2199

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix cargo test #2199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7a4c7
Run `cargo test` on CI
emilk May 24, 2023
dc6d1e3
Fix compilation of `cargo test`
emilk May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/reusable_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,14 @@ jobs:
command: doc
args: --document-private-items --no-deps --all-features

- name: Test
# Just a normal `cargo test` should always work:
- name: cargo test --all-targets
uses: actions-rs/cargo@v1
with:
command: test

# Full test of everything:
- name: cargo test --all-targets --all-features
uses: actions-rs/cargo@v1
with:
command: test
Expand Down
40 changes: 23 additions & 17 deletions crates/re_arrow_store/tests/dump.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,20 @@ fn data_store_dump_impl(store1: &mut DataStore, store2: &mut DataStore, store3:
}
sanity_unwrap(store3);

let store1_df = store1.to_dataframe();
let store2_df = store2.to_dataframe();
let store3_df = store3.to_dataframe();
assert!(
store1_df == store2_df,
"First & second stores differ:\n{store1_df}\n{store2_df}"
);
assert!(
store1_df == store3_df,
"First & third stores differ:\n{store1_df}\n{store3_df}"
);
#[cfg(feature = "polars")]
{
let store1_df = store1.to_dataframe();
let store2_df = store2.to_dataframe();
let store3_df = store3.to_dataframe();
assert!(
store1_df == store2_df,
"First & second stores differ:\n{store1_df}\n{store2_df}"
);
assert!(
store1_df == store3_df,
"First & third stores differ:\n{store1_df}\n{store3_df}"
);
}

let store1_stats = DataStoreStats::from_store(store1);
let store2_stats = DataStoreStats::from_store(store2);
Expand Down Expand Up @@ -173,12 +176,15 @@ fn data_store_dump_filtered_impl(store1: &mut DataStore, store2: &mut DataStore)
}
sanity_unwrap(store2);

let store1_df = store1.to_dataframe();
let store2_df = store2.to_dataframe();
assert!(
store1_df == store2_df,
"First & second stores differ:\n{store1_df}\n{store2_df}"
);
#[cfg(feature = "polars")]
{
let store1_df = store1.to_dataframe();
let store2_df = store2.to_dataframe();
assert!(
store1_df == store2_df,
"First & second stores differ:\n{store1_df}\n{store2_df}"
);
}

let store1_stats = DataStoreStats::from_store(store1);
let store2_stats = DataStoreStats::from_store(store2);
Expand Down
Loading