Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run clippy on public API too #2596

Merged
merged 12 commits into from
Jul 4, 2023
Merged

Run clippy on public API too #2596

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
50f6614
Turn on liniting of public interfaces
emilk Jul 3, 2023
12b6141
Turn on some more clippy lints
emilk Jul 3, 2023
56a6975
Remove unnecessary Result
emilk Jul 3, 2023
2749d36
Remove unnecessary Result
emilk Jul 3, 2023
837a52b
Silence some clippy errors
emilk Jul 3, 2023
3ca5d90
to_draw_data -> into_draw_data
emilk Jul 3, 2023
2536780
to_draw_data -> into_draw_data
emilk Jul 3, 2023
831e40d
Silence more clippy warnings
emilk Jul 3, 2023
beb135a
Fix some clippy warnings
emilk Jul 3, 2023
94adfaf
Allow unnecessary Result in MsgSendr::send
emilk Jul 3, 2023
9282a6e
Change comment
emilk Jul 4, 2023
2f477a7
Fix clippy of wasm
emilk Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/re_sdk/src/msg_sender.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ impl MsgSender {

/// Consumes, packs, sanity checks and finally sends the message to the currently configured
/// target of the SDK.
#[allow(clippy::unnecessary_wraps)] // TODO(emilk): remove the Result?
emilk marked this conversation as resolved.
Show resolved Hide resolved
pub fn send(self, rec_stream: &RecordingStream) -> Result<(), DataTableError> {
if !rec_stream.is_enabled() {
return Ok(()); // silently drop the message
Expand Down