Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new style for python extensions #3302

Merged
merged 26 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/re_types/source_hash.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions crates/re_types_builder/src/codegen/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,15 @@ pub fn remove_old_files_from_folder(folder_path: Utf8PathBuf, filepaths: &BTreeS
continue;
}

if let Some(stem) = filepath.as_str().strip_suffix("_ext.py") {
let generated_path = Utf8PathBuf::try_from(format!("{stem}.py")).unwrap();
assert!(
generated_path.exists(),
"Found orphaned {filepath} with no matching {generated_path}"
);
continue;
}

if let Some(stem) = filepath.as_str().strip_suffix("_ext.cpp") {
let generated_hpp_path = Utf8PathBuf::try_from(format!("{stem}.hpp")).unwrap();
assert!(
Expand Down
Loading
Loading