Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect propagation of field's nullability into its inner list #3352

Merged
merged 1 commit into from
Sep 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/re_types/source_hash.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer1.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer11.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer13.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer17.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer18.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer2.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer3.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer4.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer5.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer6.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions crates/re_types/src/testing/components/affix_fuzzer7.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions crates/re_types/src/testing/datatypes/affix_fuzzer1.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions crates/re_types/src/testing/datatypes/affix_fuzzer4.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions crates/re_types_builder/src/arrow_registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,23 @@ impl ArrowRegistry {
Box::new(LazyField {
name: "item".into(),
datatype: self.arrow_datatype_from_element_type(elem_type),
is_nullable: field.is_nullable,
// NOTE: Do _not_ confuse this with the nullability of the field itself!
// This would be the nullability of the elements of the list itself, which our IDL
// literally is unable to express at the moment, so you can be certain this is
// always false.
is_nullable: false,
metadata: Default::default(),
}),
length,
),
Type::Vector { elem_type } => LazyDatatype::List(Box::new(LazyField {
name: "item".into(),
datatype: self.arrow_datatype_from_element_type(elem_type),
is_nullable: field.is_nullable,
// NOTE: Do _not_ confuse this with the nullability of the field itself!
// This would be the nullability of the elements of the list itself, which our IDL
// literally is unable to express at the moment, so you can be certain this is
// always false.
is_nullable: false,
metadata: Default::default(),
})),
Type::Object(fqname) => LazyDatatype::Unresolved(fqname),
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rerun_py/rerun_sdk/rerun/_rerun2/components/affix_fuzzer16.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading