-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Visible History to support more general time queries #4123
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e6a0eba
WIP: Make visible history more general
abey79 36058ec
Fine-tuning, lints, etc.
abey79 adce254
Add heuristic to show/hide visible history UI
abey79 9c01f7f
Fix cargo docs
abey79 6f4517e
Fix time range for non-zero-based sequence timeline
abey79 648dcf9
Added some tooltips
abey79 dc39ea7
Added playground test script
abey79 34608e0
Merge branch 'main' into antoine/better-visible-history
abey79 c5b04d9
Update crates/re_data_store/src/entity_properties.rs
abey79 00629fc
Update crates/re_viewer/src/ui/selection_panel.rs
abey79 2d82812
Update crates/re_viewer/src/ui/selection_panel.rs
abey79 acd1a0e
Updated UI to use a combobox instead of the two checkboxes + some rev…
abey79 5ddf00a
Proper constants for 2D/3D space views' names
abey79 bf65bf6
Make it impossible to set "inverted" boundary (low > high)
abey79 6bc0ba7
Added TODO for `should_display_visible_history`
abey79 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to clarify, when can it happen that one is off but the other is enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How the visible history is stored is not fully normalised: there is a slight duplication:
{from: Relative(0), to: Relative(0)}
(that's whatVisibleHistory::OFF
is) disable the feature for all practical purposes.I've introduced that "enabled" bool to allow the user to disable the feature without losing their configured boundaries (ie. that checkbox next to the
Visible History
label). Overall, better UX I believe, but the cost is this check.BTW, the test against
VisibleHistory::OFF
could actually be dropped and the result would be the same. So it can be seen as an optimisation to avoid a range query when we know none is needed :)