Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External loader: don't do process IO on compute threadpool #4942

Merged
merged 1 commit into from
Jan 29, 2024
Merged

External loader: don't do process IO on compute threadpool #4942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 6 additions & 8 deletions crates/re_data_source/src/data_loader/loader_external.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ impl crate::DataLoader for ExternalLoader {
let tx = tx.clone();
let tx_feedback = tx_feedback.clone();

rayon::spawn(move || {
// NOTE: This is completely IO bound (spawning and waiting for child process), it must run on a
// dedicated thread, not the shared rayon thread pool.
_ = std::thread::Builder::new().name(exe.to_string_lossy().to_string()).spawn(move || {
re_tracing::profile_function!(exe.to_string_lossy());

let child = Command::new(exe)
Expand Down Expand Up @@ -219,12 +221,8 @@ impl crate::DataLoader for ExternalLoader {
break; // we still want to check for errors once it finally exits!
}

// NOTE: This will busy loop if there's no work available in neither
// the rayon threadpool nor the native OS threadpool.
match rayon::yield_now() {
Some(rayon::Yield::Executed) => {}
_ => std::thread::yield_now(),
}
// NOTE: This will busy loop if there's no work available in the native OS threadpool.
std::thread::yield_now();

continue;
}
Expand Down Expand Up @@ -259,7 +257,7 @@ impl crate::DataLoader for ExternalLoader {
re_log::debug!(loader = ?exe, ?filepath, "compatible external loader found");
tx_feedback.send(CompatibleLoaderFound).ok();
}
});
})?;
}

re_tracing::profile_wait!("compatible_loader");
Expand Down