Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save recordings from web viewer #5488

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Save recordings from web viewer #5488

merged 6 commits into from
Mar 13, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 13, 2024

What

You can now save recordings from the web viewer. The UI is admittedly pretty ugly (we use rfd), but it works.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🕸️ web regarding running the viewer in a browser 📺 re_viewer affects re_viewer itself labels Mar 13, 2024
Copy link

Size changes

Name main 5488/merge Change
incremental_logging.rrd 0 MiB 0 MiB +100.00%

crates/re_ui/src/command.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/app.rs Outdated Show resolved Hide resolved
emilk and others added 2 commits March 13, 2024 11:03
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
@emilk emilk merged commit a16b61a into main Mar 13, 2024
34 checks passed
@emilk emilk deleted the emilk/save-on-web branch March 13, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 📺 re_viewer affects re_viewer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants