Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Classic Python SDK #977

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Remove Classic Python SDK #977

merged 3 commits into from
Jan 30, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 29, 2023

cleaning

just py-run-all works as expected afterwards.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

jondo2010
jondo2010 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@jondo2010 jondo2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in a separate cleanup pass, I'd like to move all the from rerun.components.* import statements to the top.

@emilk emilk merged commit 3f7320e into main Jan 30, 2023
@emilk emilk deleted the emilk/remove-classic-python-sdk branch January 30, 2023 08:53
@emilk
Copy link
Member Author

emilk commented Jan 30, 2023

Go for it!

@jondo2010 jondo2010 mentioned this pull request Jan 30, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jondo2010 jondo2010 jondo2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilk @jondo2010 @teh-cmc