New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run test benches rather than full bench on CI #992

Merged

jleibs merged 4 commits into main from jleibs/test_benches_only

Jan 30, 2023

Member

jleibs commented Jan 30, 2023 •

edited

Loading

With the benchmark broken, we correctly see a failure after only a minute:

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

jleibs added 4 commits

January 30, 2023 15:20


          Add --all-targets to the cargo test invocation

e6dba59


          Only run full criterion benchmarks on push to main

3cfe174


          Re-break the benchmarks to make sure they break

9a2c8a9


          Fix the benchmark again

2f75325

jleibs marked this pull request as ready for review

January 30, 2023 14:43

emilk approved these changes

View reviewed changes

jleibs merged commit 51191b7 into main

jleibs deleted the jleibs/test_benches_only branch

January 30, 2023 14:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment