Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build+Deploy Python Wheels in CI #996

Merged
merged 31 commits into from
Feb 2, 2023
Merged

Build+Deploy Python Wheels in CI #996

merged 31 commits into from
Feb 2, 2023

Conversation

jondo2010
Copy link
Contributor

@jondo2010 jondo2010 commented Jan 30, 2023

New and improved Python workflows for CI/dev/release:

  • Python workflows are run for any PRs that touch python code. Wheels are built and spot-checked for Linux + Windows here.
  • First the linter is run, and gates all the subsequent jobs as an early-fail
  • For pushed tags and to main, the mac wheels are also built (these take 25-35 mins)
  • For refs landing on main, i.e., a PR was merged, all the mac,windows,linux wheels are collected into a "development" release on GitHub.
  • When a tag starting with "v", i.e, "v0.1.0" is pushed, a "tagged-release" job is run at the end that releases to GitHub and additionally to PyPI

Also:

  • upgraded numpy, pyo3, maturin
  • fixed the rerun entrypoint in pyproject.toml, so that after installing the wheel (or running just py-build), the rerun cmd is available on the CLI.

Closes #352

  • Test the tagged-releases.
  • Need to put PYPI_PASSWORD in the GH secrets section.
  • Pre-launch: Switch the GH secrets and repo to use pypi instead of testpypi

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@jondo2010 jondo2010 changed the title Build Python Wheels in CI Build+Deploy Python Wheels in CI Feb 1, 2023
@jondo2010 jondo2010 marked this pull request as ready for review February 1, 2023 13:21
@jleibs jleibs self-requested a review February 1, 2023 17:07
.github/workflows/python.yml Outdated Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
rerun_py/README.md Outdated Show resolved Hide resolved
rerun_py/build.rs Outdated Show resolved Hide resolved
- Rename the python crate to `rerun_py` to match the folder
@emilk
Copy link
Member

emilk commented Feb 2, 2023

When a tag starting with "v", i.e, "v0.1.0" is pushed, a "tagged-release" job is run at the end that releases to GitHub and additionally to PyPI

Please update RELEASES.md to reflect this naming scheme!

.github/workflows/python.yml Show resolved Hide resolved
rerun_py/pyproject.toml Outdated Show resolved Hide resolved
rerun_py/build.rs Outdated Show resolved Hide resolved
rerun_py/build.rs Outdated Show resolved Hide resolved
@jondo2010 jondo2010 merged commit b056275 into main Feb 2, 2023
@jondo2010 jondo2010 deleted the john/wheel_building branch February 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-built Python wheels for our users
3 participants