Refactor InstanceId
#999
Merged
Refactor InstanceId
#999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
approved these changes
Jan 31, 2023
| /// A special value indicating that this [`Instance]` is referring to all instances, | ||
| /// for instance all points in a point cloud entity. | ||
| /// | ||
| /// In some contexts it is also used to mean no instances. |
There was a problem hiding this comment.
That seems unexpected and probably needs a few more words.
The fact that InstancePathHash::None happens to specify SPLAT makes sense.
Are there other contexts where SPLAT means none?
There was a problem hiding this comment.
I removed the comment. It wasn't even correct. Even in an InstancePath, SPLAT means "all the instances of the entity".
crates/re_viewer/src/ui/view_spatial/scene/scene_part/images.rs
Outdated
Show resolved
Hide resolved
|
Also, agree with the proposed rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies and renamed
InstanceIdtoInstancePath(because that is what it is).I wonder if
Instanceshould be renamedInstanceIndexorInstanceId, since the concept "instance" means an instance of an entity, e.g. a point in a point cloud.Checklist
CHANGELOG.md(if this is a big enough change to warrant it)