This repository has been archived by the owner on Oct 28, 2023. It is now read-only.
Add support for Jack and create mechanism to use polyphony etc. in a modular way. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nth take arguments of generic types.
… that polyphony is handled correctly and some doc improvements.
piedoom
approved these changes
Dec 18, 2018
|
Awesome work all around, thank you so much! |
|
My pleasure :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for creating such a big pull request without much discussion. I would totally understand if you were to reject this pull request just because of its size.
Changes
It's probably the easiest to get an overview of the changes by running
cargo doc --no-deps --features jack-backendand looking at the (new) documentation.Some plugins also need the notion of "context" (e.g. state that is shared between multiple voices of a polyphonic instrument). I had an idea to do this in a fancy way, but it seems that this would only cause more trouble. So I'm probably going to add a "context" parameter to most methods in the
backend::Plugintrait. I will experiment with that in a separate branch. I wanted to create this pull request before that change, because otherwise it will only get bigger and bigger.