Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to genType #40

Closed
cristianoc opened this issue Oct 1, 2018 · 6 comments
Closed

Rename to genType #40

cristianoc opened this issue Oct 1, 2018 · 6 comments

Comments

@cristianoc
Copy link
Collaborator

@cristianoc cristianoc commented Oct 1, 2018

Gradually rename the project to genType, with small extensions followed by one breaking change.

@cristianoc
Copy link
Collaborator Author

@cristianoc cristianoc commented Oct 1, 2018

This allows to use gentypeconfig.json:
cristianoc/genFlow@8a8250d

Loading

@nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Oct 1, 2018

ohh nice, so one tool to generate multiple targets?

Loading

@tutturen
Copy link

@tutturen tutturen commented Oct 1, 2018

I would love a tool that generates types for Flow, TypeScript and vanilla JS in one go. That would make it a joy to write js libraries in Reason.

Loading

@cristianoc
Copy link
Collaborator Author

@cristianoc cristianoc commented Oct 1, 2018

@tutturen that’s definitely doable. The Flow and TS generated code is different, but we already have 2 extensions, so it’s easy to write both files.
For Flow and vanilla, the easiest is to just generate Flow and ignore the types for vanilla. The requirement is to have eg Babel in the pipeline. But it’s simpler than having a third kind of file generated at the same time.

Loading

@cristianoc
Copy link
Collaborator Author

@cristianoc cristianoc commented Oct 1, 2018

Branch for the final renaming: https://github.com/cristianoc/genFlow/pull/44.

Loading

@cristianoc
Copy link
Collaborator Author

@cristianoc cristianoc commented Oct 2, 2018

Done.

Loading

@cristianoc cristianoc closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants