Skip to content
This repository has been archived by the owner on Nov 13, 2023. It is now read-only.

genType doesn't support BS 8.3 flexible filenames #477

Closed
vknez opened this issue Nov 18, 2020 · 1 comment · Fixed by #478
Closed

genType doesn't support BS 8.3 flexible filenames #477

vknez opened this issue Nov 18, 2020 · 1 comment · Fixed by #478

Comments

@vknez
Copy link

vknez commented Nov 18, 2020

I was really excited to use the newly enabled flexible filenames in ReScript compiler, such as AppModal.web.re, AppModal.android.re or 404.re, but I realized that the latest genType doesn't support them.

The generated .gen.tsx files currently contain invalid TypeScript identifiers:

const AppModal.webBS = require('./AppModal.web.bs');
...
const 404BS = require('./404.bs');

https://rescript-lang.org/blog/release-8-3-pt1#more-flexible-filename-support

Any chance we can have such a feature implemented soon? There's a lot of boilerplate needed currently to work around those limitations.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant