Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optional arguments in bindings #206

Open
cknitt opened this issue Apr 1, 2024 · 0 comments
Open

Use optional arguments in bindings #206

cknitt opened this issue Apr 1, 2024 · 0 comments

Comments

@cknitt
Copy link
Collaborator

cknitt commented Apr 1, 2024

Many JavaScript APIs have methods with trailing optional args and are currently bound in Core as multiple different functions for different argument counts.

However, since ReScript 11, we can have trailing optional args in functions/bindings without needing a () at the end anymore. This allows us to create more idiomatic bindings for such cases, corresponding more closely to the original JS API.

I have already created the following PRs for a some such cases:

There are quite a few other bindings left that should be changed in a similar way (e.g., Date.make).

For some such functions, the trailing undefineds emitted by the 11.0 compiler for the omitted arguments will be problematic and therefore ReScript 11.1 will be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant